Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using rusttype instead of freetype? #2325

Closed
fschutt opened this issue Jan 18, 2018 · 6 comments
Closed

Using rusttype instead of freetype? #2325

fschutt opened this issue Jan 18, 2018 · 6 comments

Comments

@fschutt
Copy link
Contributor

@fschutt fschutt commented Jan 18, 2018

Just a question, but is the webrender team aware of rusttype? Is there any reason why you are using freetype instead? Right now, you have to ship the freetype DLL with the binary, which complicates deployment.

Is it planned to migrate to rusttype in the future or is the team not interested?

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 18, 2018

Yep, we're aware. rusttype doesn't have enough features to give native looking fonts (e.g. it's missing hinting and opentype outline support).

You shouldn't need to ship freetype though, instead you can just use the system freetype.

@fschutt
Copy link
Contributor Author

@fschutt fschutt commented Jan 18, 2018

What do you mean by "system freetype"? On Windows, you still have to ship the DLL, or am I missing something?

@leeoniya
Copy link

@leeoniya leeoniya commented Jan 18, 2018

isnt the plan to use pathfinder for glyph & path rendering? it already supports hinting and outlines i think.

https://github.com/pcwalton/pathfinder

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 18, 2018

On Windows WebRender uses DirectWrite and on macOS it uses CoreGraphics so we don't need FreeType on those platforms.

Pathfinder doesn't have sufficient hinting support to replace the OS stuff yet, we're not exactly sure what are our plan to deal with that will be.

@fschutt
Copy link
Contributor Author

@fschutt fschutt commented Jan 18, 2018

Ah ok. Should I leave this open? If rusttype would have these features, would it be appropriate to switch?

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 18, 2018

We'll close it for now and can file something new if rusttype becomes more mature.

@fschutt fschutt closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.