Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: white bars on tabs when loading whatsapp #2327

Closed
staktrace opened this issue Jan 19, 2018 · 5 comments
Closed

regression: white bars on tabs when loading whatsapp #2327

staktrace opened this issue Jan 19, 2018 · 5 comments

Comments

@staktrace
Copy link
Contributor

@staktrace staktrace commented Jan 19, 2018

Filing for https://bugzilla.mozilla.org/show_bug.cgi?id=1431575

Narrowed the regression range down to:

*   4e6310e8 Auto merge of #2257 - zakorgy:patch-1, r=nical
|\
| * 9066f565 Remove legacy shader part from build_shader_strings
*   92959212 Auto merge of #2255 - glennw:fix-3dxf, r=kvark
|\
| * c66209e1 Make incompatible coordinate system detection more conservative.
* 3a905e7e Auto merge of #2251 - Gankro:deserialize_in_place, r=glennw
* 52c3ecef Stop using the serde_derive feature for no good reason
* f879af5f Update serde to 1.0.27, removing some of the patch hacks

Let me know if you want it narrowed down further, I'll have to do builds.

@glennw
Copy link
Member

@glennw glennw commented Jan 19, 2018

No need to narrow it down further, that's a big help already, thanks!

@Darkspirit
Copy link

@Darkspirit Darkspirit commented Feb 14, 2018

I think this got fixed by one of them: 30f2cd5...e7c95ae
Plausible?

@glennw
Copy link
Member

@glennw glennw commented Feb 14, 2018

Yep, definitely plausible - there's a couple of patches in WR that may have fixed it, or it could also have been the external clip ID fix in Gecko that fixed it.

@glennw
Copy link
Member

@glennw glennw commented Feb 14, 2018

Oh, it could also be the partial rendering PR from that commit range you referenced above.

@Darkspirit
Copy link

@Darkspirit Darkspirit commented Feb 19, 2018

That's the fix range I found. The visual issue was gone afterwards. So this issue could get closed.

@glennw glennw closed this Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.