Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upassertion failure in clear_target: DEPTH_WRITEMASK is 0 #2339
Comments
|
Good, means we have a logic bug and now my new checks panic on it. Hope it's not too annoying for Gecko. I'll look into it. |
|
Hmm, scanning the code it seems pretty solid on enforcing the invariants about depth clearing. Could we get a more detailed @staktrace (no pun!)? |
|
The log pointed to in the bug has a stacktrace which isn't properly symbolicated. I pulled the xul.sym file for the build (it's in the target.crashreporter-symbols-full.zip artifact that's uploaded for the build job corresponding to the test job that failed) and did some symbolication-by-hand for the addresses. I got the xul.dll base address from the c6b19016-5e9e-4177-8bee-9530b869c841.extra artifact on the test job itself. Below is the stacktrace with the frames I symbolicated. I doubt it's very useful though:
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1432886 to make the symbolication better by default. Edited to fill in a couple of the mozilla_dump_image frames as well, those aren't really in mozilla_dump_image. |
|
Thanks!
The fact it's an intermittent is worrying though. The assertion is pretty deterministic. |
|
Apparently it was on a broken machine, https://bugzilla.mozilla.org/show_bug.cgi?id=1432819#c2 |
Filing for https://bugzilla.mozilla.org/show_bug.cgi?id=1432819, seems to be an intermittent failure in mozilla-central CI. The panic is coming from this line - apparently both arguments are 0 so the debug_assert_ne is failing.