Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture portability: fonts #2342

Closed
kvark opened this issue Jan 25, 2018 · 0 comments
Closed

Capture portability: fonts #2342

kvark opened this issue Jan 25, 2018 · 0 comments

Comments

@kvark
Copy link
Member

@kvark kvark commented Jan 25, 2018

Font structures are platform specific, they prevent us from replaying a capture on a different machine. Technically, this should only affect SCENE-level captures, but we currently don't have an ability to only save the FRAME level without also saving/loading the basics.

bors-servo added a commit that referenced this issue Jan 29, 2018
Capture font portability

Fixes #2342
Also wraps the `UpdateResources` into device frame begin/end, since we may need to access GL context there (and I'm not sure how it works otherwise - maybe it's not used by another other than capturing?).

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2349)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.