Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet notifications when pipelines are removed. #2345
Closed
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Feb 7, 2018
Track removed pipelines and expose them in the renderer. This information is useful to manage the lifetime of resources that are owned by the embedder and used by the renderer such as external images. Fixes #2345. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2347) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use epochs (see
Renderer::flush_rendered_epochs) to track where the renderer is at and manage the lifetime of resources that are used by the renderer but owned by another thread. This works well except when we remove a pipeline, because we never get the notification for the last epoch of that pipeline and this results in leaks in gecko as we keep waiting for a rendered epoch notification that never comes.Having special code to handle this in gecko is tricky because knowing that a pipeline is removed at the api level doesn't say anything about when it will not be used by the renderer anymore.
We need an equivalent of
flush_rendered_epochsthat signals all of the removed pipelines.See https://bugzilla.mozilla.org/show_bug.cgi?id=1432708