Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOn Mac, multi-threaded font rasterization spends all of its time in CGContext creation and destruction, waiting for locks #2406
Assignees
Labels
Comments
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 17, 2018
This should avoid locks and save some memory allocation time. Closes servo#2406.
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 18, 2018
This should avoid locks and save some memory allocation time. Closes servo#2406.
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 18, 2018
This should avoid locks and save some memory allocation time. Closes servo#2406.
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 19, 2018
This should avoid locks and save some memory allocation time. Closes servo#2406.
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 19, 2018
This should avoid locks and save some memory allocation time. Closes servo#2406.
bors-servo
added a commit
that referenced
this issue
Sep 19, 2018
Recycle Core Graphics contexts when rasterizing glyphs. This should avoid locks and save some memory allocation time. Closes #2406. r? @gw3583 (or whoever wants to) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3071) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 20, 2018
This should avoid locks and save some memory allocation time. This patch also updates Pathfinder so we can keep the `core-graphics` crate versions in sync. Closes servo#2406.
pcwalton
added a commit
to pcwalton/webrender
that referenced
this issue
Sep 20, 2018
This should avoid locks and save some memory allocation time. This patch also updates Pathfinder so we can keep the `core-graphics` crate versions in sync. Closes servo#2406.
bors-servo
added a commit
that referenced
this issue
Sep 20, 2018
Recycle Core Graphics contexts when rasterizing glyphs. This should avoid locks and save some memory allocation time. Closes #2406. r? @gw3583 (or whoever wants to) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3071) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Profile: https://perfht.ml/2BnYout
For example, you can see that
CGBitmapContextCreateends up calling into_RIPAddContextToContextListwhich grabs a lock. With multiple WRWorker threads, locking overhead seems to dwarf actual rasterization.