Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`wrench --save yaml load capture` doesn't work #2583

Closed
Gankra opened this issue Mar 28, 2018 · 1 comment
Closed

`wrench --save yaml load capture` doesn't work #2583

Gankra opened this issue Mar 28, 2018 · 1 comment
Assignees
@kvark
Labels
area: infrastructure type: enhancement

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented Mar 28, 2018

The example renders fine, and the yaml_frames dir is created, but it's empty.
@Gankra
Copy link
Contributor Author

@Gankra Gankra commented Mar 28, 2018

note: this appears to not work because load injects content at a level below --save yaml (yaml_frame_writer) reads. A potential solution is to just push yaml_frame_writer lower down the stack.
@gw3583 gw3583 mentioned this issue Jun 18, 2018
Closed
@kvark kvark mentioned this issue Sep 10, 2018
Merged
@kvark kvark self-assigned this Sep 10, 2018
bors-servo added a commit that referenced this issue Sep 11, 2018
@bors-servo
Auto merge of #3038 - kvark:capture-record, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
525786a 
Basic recording support for loaded captures

Fixes #2583 (more follow-up is expected though for correctness)

This change makes the capture infrastructure play better with the display-list-based recording. It produces a fake `SetDisplayList` message to be recorded based on the (already) loaded scene. Result isn't always consumable by the YAML reader (there are correctness issues, and I bet the YAML reading-writing loop isn't sinless either, given that it was never tested on big scenes, typically produced by capturing from Gecko). Here is the `basic` example replayed from YAML:
![wrench-yaml-from-capture](https://user-images.githubusercontent.com/107301/45302345-10f60500-b4e1-11e8-9e94-aa4c82b2cb7d.png)

YAML is at least always generated, and it gives an easier workflow for developers trying to reproduce a captured bug in a YAML reftest.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3038)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
area: infrastructure type: enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kvark @Gankra
You can’t perform that action at this time.