Display items with off-screen positions that are translated to be on-screen incorrectly culled out #262

pcwalton · 2016-04-16T01:32:21Z

Test case:

<!DOCTYPE html>
<div style="transform: translateX(-2000px)">
    <div style="position: absolute; top: 0; left: 2000px;">X</div>
</div>

This breaks http://apple.com/.

daoshengmu · 2016-07-09T15:57:48Z

I can help investigate. I notice the below test case is wrong as well.

<div style="transform: translateX(0px)">
    <div style="position: absolute; top: 0; left: 0px;">X</div>
</div>

daoshengmu · 2016-07-14T00:12:20Z

I think I have fixed the first test case via this way at frame::add_items_to_target():

let rect = info.world_transform.transform_rect(&item.rect
                  .translate(&info.offset_from_current_layer));

Because it forgets to append the world transform from it parent. I have checked http://apple.com/ that works well.

The test case of left: 0px; is another case that the letter x is clipped. Probably there is something wrong on the scissor test. I will follow up for this.

@pcwalton Do you think it is ok for me to send a PR?

tschneidereit · 2016-07-14T09:14:29Z

@daoshengmu, if you already have a patch that fixes the issue for you, it's best to just open a PR. If something's wrong about it, then that can be discussed in the PR itself instead of here. This way, you don't need to wait for a response here and then again in the PR after you opened it.

glennw · 2016-08-08T22:04:52Z

No longer an issue in WR2.

pcwalton added the type: bug label Apr 16, 2016

daoshengmu mentioned this issue Jul 14, 2016

The transform rect of draw list items needs to append parent's world transform. #313

Closed

glennw closed this Aug 8, 2016

servo / webrender

Display items with off-screen positions that are translated to be on-screen incorrectly culled out #262

Display items with off-screen positions that are translated to be on-screen incorrectly culled out #262

pcwalton commented Apr 16, 2016

daoshengmu commented Jul 9, 2016

daoshengmu commented Jul 14, 2016

tschneidereit commented Jul 14, 2016

glennw commented Aug 8, 2016

servo / webrender

Join GitHub today

Display items with off-screen positions that are translated to be on-screen incorrectly culled out #262

Display items with off-screen positions that are translated to be on-screen incorrectly culled out #262

Comments

pcwalton commented Apr 16, 2016

daoshengmu commented Jul 9, 2016

daoshengmu commented Jul 14, 2016

tschneidereit commented Jul 14, 2016

glennw commented Aug 8, 2016