Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered elements are clipped if their bounds change via animated properties #2668

Closed
mstange opened this issue Apr 17, 2018 · 3 comments
Closed
Assignees

Comments

@mstange
Copy link
Contributor

@mstange mstange commented Apr 17, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1454763

>> Testcase <<

In this testcase, the rounded border is sometimes not rendered completely. The testcase applies a filter to a stationary element which wraps an element whose transform is animated. The bounds of the filter surface are dependent on the animated property.

@glennw
Copy link
Member

@glennw glennw commented Apr 17, 2018

I'll look at this today.

@glennw glennw self-assigned this Apr 17, 2018
@Darkspirit
Copy link

@Darkspirit Darkspirit commented Apr 17, 2018

I think this is a downstream regression. (?)

@mstange
Copy link
Contributor Author

@mstange mstange commented Apr 17, 2018

The downstream change has exposed an existing WebRender bug.

glennw pushed a commit to glennw/webrender that referenced this issue Apr 18, 2018
When the local rect of a picture primitive changes (due to a
child primitive or picture being attached to an animating
scroll node), we need to invalidate the GPU cache entry for
this picture. This ensures that the correct local rect is
uploaded to the GPU shaders.

Fixes servo#2668.
bors-servo added a commit that referenced this issue Apr 18, 2018
Fix filtered elements being clipped during property animation.

When the local rect of a picture primitive changes (due to a
child primitive or picture being attached to an animating
scroll node), we need to invalidate the GPU cache entry for
this picture. This ensures that the correct local rect is
uploaded to the GPU shaders.

Fixes #2668.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2669)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.