Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBlendMode::SubpixelWithBgColor text rendering should still be allowed inside transparent groups #2670
Assignees
Labels
Comments
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Apr 27, 2018
When a subpixel text run has a specified background color, we can safely draw it into an off-screen surface. Fix a bug in the renderer where the shader color mode was being set before the shader was bound. Add support in wrench for specifying the background color of a text run. Add a reftest that checks offscreen surface + bg color subpixel text is the same as subpixel text on a normal background. Fixes servo#2670.
|
Fix is #2701. |
glennw
pushed a commit
to glennw/webrender
that referenced
this issue
Apr 30, 2018
When a subpixel text run has a specified background color, we can safely draw it into an off-screen surface. Fix a bug in the renderer where the shader color mode was being set before the shader was bound. Add support in wrench for specifying the background color of a text run. Add a reftest that checks offscreen surface + bg color subpixel text is the same as subpixel text on a normal background. Fixes servo#2670.
bors-servo
added a commit
that referenced
this issue
May 1, 2018
Allow subpixel with specified background color in offscreen targets. When a subpixel text run has a specified background color, we can safely draw it into an off-screen surface. Fix a bug in the renderer where the shader color mode was being set before the shader was bound. Add support in wrench for specifying the background color of a text run. Add a reftest that checks offscreen surface + bg color subpixel text is the same as subpixel text on a normal background. Fixes #2670. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2701) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the default theme on Mac, overflowing tab titles no longer use subpixel AA. However, the text in the tab titles uses a font smoothing background color, and
BlendMode::SubpixelWithBgColoris able to render onto transparency without any problems. So I think we need to adjust the logic that disables subpixel AA in this case, so that SubpixelWithBgColor text blending is still allowed.