Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrench DPI scaling is wrong when loading capture #2697

Closed
mstange opened this issue Apr 26, 2018 · 1 comment
Closed

Wrench DPI scaling is wrong when loading capture #2697

mstange opened this issue Apr 26, 2018 · 1 comment
Labels
difficulty: easy type: bug

Comments

@mstange
Copy link
Contributor

@mstange mstange commented Apr 26, 2018

I have taken a WR capture on HiDPI Mac. Loading the capture in wrench shows a number of problems:

  1. The window is twice the width that it should be.
  2. Only the top left quadrant of the scene is rendered, the rest of the wrench window is white.
  3. The vertical offset is wrong - parts at the top are clipped away, and the rendered scene moves down if I reduce the height of the window.
@kvark
Copy link
Member

@kvark kvark commented May 3, 2018

The OSX hiDPI story has recently been fixed in winit, so it might be fixed when we update to latest glutin/winit.
@zakorgy zakorgy mentioned this issue May 24, 2018
Merged
bors-servo added a commit that referenced this issue May 27, 2018
@bors-servo
Auto merge of #2772 - zakorgy:winit, r=gw3583
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3829687 
Replace usage of glutin with winit where it is possible

I have updated the glutin to `0.15` and winit to `0.13.1`. This may fix #2697, i didn't have the chance to test these changes on Mac.

Also I replaced glutin with winit, where it was possible. This change can help the transition to various backends in the future.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2772)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Replace usage of glutin with winit where it is possible
2 participants
@kvark @mstange
You can’t perform that action at this time.