Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updrop-shadow() filter is not updated in response to off-main-thread animations #2721
Comments
|
So it looks like the shadow rendering is updated when the size of the input changes, but not when only the position of the input changes. And when the size of the input changes, the updated shadow is drawn into a rectangle that was computed based on the non-updated bounds. |
gw3583
added a commit
to gw3583/webrender
that referenced
this issue
Jun 4, 2018
If the local rect of the content of a drop-shadow is changing each frame, we also need to invalidate the GPU cache data for the drop-shadow primitive. Unfortunately we don't have a way in wrench right now to create a regression test for this. Fixes servo#2721.
|
Fix is #2799. |
bors-servo
added a commit
that referenced
this issue
Jun 4, 2018
Invalidate drop-shadow data when local rect is animating. If the local rect of the content of a drop-shadow is changing each frame, we also need to invalidate the GPU cache data for the drop-shadow primitive. Unfortunately we don't have a way in wrench right now to create a regression test for this. Fixes #2721. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2799) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://bugzilla.mozilla.org/show_bug.cgi?id=1458661
Testcase 1
Testcase 2
Testcase 3 (works correctly but might still be worth confirming with once the bug is fixed)
In these testcases the black shadow lags behind. In the second testcase, the shadow gets squeezed and stretched in funny ways as the bounds of the filter input change.