Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRender forgets about the contents of blob images without updating the dirty rect #2771

Closed
jrmuizel opened this issue May 23, 2018 · 3 comments
Closed

WebRender forgets about the contents of blob images without updating the dirty rect #2771

jrmuizel opened this issue May 23, 2018 · 3 comments
Assignees
@kvark
Labels
bugzilled type: bug

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented May 23, 2018

STR:

  1. draw a blob image
  2. draw the blob image offscreen
  3. update the blob with a small dirty rect and draw it on screen
    In the rendering request for 3. the dirty rect is that of the update, but WebRender has forgotten about the rest of the content of the blob image.

There's a raw test that shows off this behaviour here: jrmuizel@c85dab4
@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented May 23, 2018

Maybe we need to hook up something like the eviction_notice stuff to know when to reset the dirty_rect?
@glennw or @nical thoughts?
@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented May 23, 2018

Note: this is causing https://bugzilla.mozilla.org/show_bug.cgi?id=1463792
@kvark kvark self-assigned this May 24, 2018
@kvark kvark mentioned this issue May 24, 2018
Merged
@kvark
Copy link
Member

@kvark kvark commented May 24, 2018 •
edited

@jrmuizel my thoughts have been expressed in #2774 :D
bors-servo added a commit that referenced this issue May 24, 2018
@bors-servo
Auto merge of #2774 - kvark:dirty-blob, r=jrmuizel
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
229ddd3 
Discard the dirty rect of evicted texture cache entries

Fixes #2771
Includes the raw test by @jrmuizel

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2774)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvark kvark

Labels
bugzilled type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kvark @jrmuizel
You can’t perform that action at this time.