Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box shadows don't render properly on mac in some cases #2773

Closed
staktrace opened this issue May 24, 2018 · 5 comments
Closed

Box shadows don't render properly on mac in some cases #2773

staktrace opened this issue May 24, 2018 · 5 comments
Assignees

Comments

@staktrace
Copy link
Contributor

@staktrace staktrace commented May 24, 2018

Filing for bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1452351 - the bug has a reduced test case that shows the problem on Mac. Bisection indicated the regression appeared somewhere in this range:

*   5cb71f0f Auto merge of #2499 - kvark:revert-fix, r=staktrace
|\
| * 9b069b7b Revert "textureSize() workaround for Angle/NV" for (somehow) causing text rendering issues on OSX.
* |   ce9c75b5 Auto merge of #2496 - jrmuizel:div, r=kvark
|\ \
| |/
|/|
| * fa1090c4 Do division and mod on unsigned integers
* |   7e459e81 Auto merge of #2497 - glennw:bi-opt, r=kvark
|\ \
| |/
|/|
| * 584459c6 Small optimization for the brush_image shader.
|/
* f3af2632 Auto merge of #2487 - glennw:bs-clip15, r=kvark
* 18cc8adb Handle minimal shadow rects with fractional offsets / sizes.
* 81f55acd Switch box-shadows to be a clip source instead of a picture.

So I'm guessing it's from #2487.

@Darkspirit
Copy link

@Darkspirit Darkspirit commented Jun 6, 2018

Will be fixed when #2799 lands in Gecko.

This can be closed.

@staktrace
Copy link
Contributor Author

@staktrace staktrace commented Jun 6, 2018

I'm still seeing the problem with #2799 applied :(

@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Jun 6, 2018

The fix in #2799 was related to drop-shadows only, not box shadows. Specifically it was to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1458661. It looks like I incorrectly commented in https://bugzilla.mozilla.org/show_bug.cgi?id=1452351 when I meant to comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1458661, sorry!

@pcwalton
Copy link
Collaborator

@pcwalton pcwalton commented Sep 17, 2018

Couldn't reproduce. Trying to get more info from reporter.

@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Feb 4, 2019

Marked fixed in related bugzilla bug.

@gw3583 gw3583 closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.