Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upZero width borders break WR #2812
Closed
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Jun 18, 2018
Handle zero-width sized borders without crashing. Fixes #2812. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2822) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While updating to the latest WR I discovered the following YAML:
root: items: - type: stacking-context bounds: [0, 0, 500, 500] items: - type: border bounds: [ 0, 0, 50, 50 ] width: [ 0, 0, 0, 0 ] border-type: normal style: [ solid, solid, solid, solid ] color: [ blue, blue, blue, blue ]breaks WR with the following assertion:
I think this has to do with moving borders to the brush code path and caching them in the texture cache.
Probably Gecko/Servo stop completely zero width borders from hitting WR at all. Should WR treat this as a no op rather than hitting an assertion?