Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inset box-shadow gets cut off at certain sizes #2818

Closed
Gankra opened this issue Jun 15, 2018 · 3 comments
Closed

inset box-shadow gets cut off at certain sizes #2818

Gankra opened this issue Jun 15, 2018 · 3 comments
Labels
bugzilled type: bug

Comments

@Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 15, 2018

https://bugzilla.mozilla.org/show_bug.cgi?id=1463802

bad:

data:text/html,<div style="height: 133.6px; width: 133.6px;"><div style="box-shadow: 0px 0px 18px inset; height: 100%;"></div></div>

good:

data:text/html,<div style="height: 134px; width: 134px;"><div style="box-shadow: 0px 0px 18px inset; height: 100%;"></div></div>
@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Jun 18, 2018

The test above doesn't reproduce for me on Linux. However, the website in the bugzilla bug does show the issue, so I'll do some testing with that.
@Darkspirit
Copy link

@Darkspirit Darkspirit commented Jun 18, 2018

I can reproduce the bug with "bad" at 200% zoom and "good" at 210% (on Debian Testing / GTX 1060).
gw3583 added a commit to gw3583/webrender that referenced this issue Jun 18, 2018
@gw3583
Fix box shadows when inner mask rect has invalid size.
f828118 
Fixes servo#2818.
@gw3583 gw3583 mentioned this issue Jun 18, 2018
Merged
@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Jun 18, 2018

Fix is #2824
bors-servo added a commit that referenced this issue Jun 18, 2018
@bors-servo
Auto merge of #2824 - gw3583:inset-bs, r=mrobinson
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cb60fb5 
Fix box shadows when inner mask rect has invalid size.

Fixes #2818.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2824)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilled type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@kvark @Gankra @Darkspirit @gw3583
You can’t perform that action at this time.