Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First call to set_output_document has no effect #2820

Closed
nc4rrillo opened this issue Jun 17, 2018 · 2 comments
Closed

First call to set_output_document has no effect #2820

nc4rrillo opened this issue Jun 17, 2018 · 2 comments
Labels
difficulty: easy help wanted type: bug

Comments

@nc4rrillo
Copy link
Contributor

@nc4rrillo nc4rrillo commented Jun 17, 2018

The frame output example stopped working some time ago.

The issue seems to be that frame messages (which contain EnableFrameOutput are processed after the call to build_scene resulting in an empty list of output_pipelines getting passed to the FrameBuilder.

Moving the processing of frame messages to before the call to build_scene fixes the issue. There is a separate issue where nothing is rendered in the example.
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Jun 20, 2018

I'll pick this up 👍
@hgallagher1993 hgallagher1993 mentioned this issue Jul 4, 2018
Closed
@hgallagher1993 hgallagher1993 mentioned this issue Aug 7, 2018
Merged
bors-servo added a commit that referenced this issue Aug 7, 2018
@bors-servo
Auto merge of #2952 - hgallagher1993:local_branch, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0634d02 
Submit transaction with frame output enabled before transaction with …

…DL in frame_output.rs

Fix for #2820 and closed #2866 in favour of this.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2952)
<!-- Reviewable:end -->
@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Aug 24, 2018 •
edited

Was looking through the easy tagged tasks just now and this can be closed 👍
@kvark kvark closed this Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy help wanted type: bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@kvark @hgallagher1993 @nc4rrillo
You can’t perform that action at this time.