Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport tiled clip images #2852
Comments
|
Drawing the tiles into an an intermediate surface and using the latter as the clip source would make sense here. |
We don't currently support tiled blobs for clip masks (see issue servo#2852). This patch detects that case, and skips applying a clip mask in that case. It's not ideal, but it's better than crashing inside the resource cache, which is the current behavior.
|
I haven't thought about this too deeply, but I don't think we need an intermediate surface. I think to support this, we need to: (1) Determine which of the image tiles overlap the clip mask bounds (we should be able to reuse some of the current tile visibility code for this). |
|
I think that the clip mask and what I called the intermediate surface are the same thing in my head (I haven't touched the masking code much so I'm a bit fuzzy about the terminology) |
|
Will take a look at this. |
Skip clip masks with tiled blobs, instead of crashing. We don't currently support tiled blobs for clip masks (see issue #2852). This patch detects that case, and skips applying a clip mask in that case. It's not ideal, but it's better than crashing inside the resource cache, which is the current behavior. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3219) <!-- Reviewable:end -->
When we request image for a clip source that is an image, we never supply a tile:
This breaks the resource cache expectations that a tiled image would only be requested with specific tiles.
cc @nical @aosmond