Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly segment brushes which have clips with different positioning nodes #2858

Closed
mrobinson opened this issue Jun 28, 2018 · 1 comment
Closed

Comments

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Jun 28, 2018

We currently choose to not include clips with different positioning nodes, but compatible coordinate systems. If we do this, we would need to resegment during scrolling, perhaps looking at the ancestry of the positioning nodes to see if it is necessary.

@gw3583
Copy link
Collaborator

@gw3583 gw3583 commented Feb 4, 2019

At least for now, we plan to only segment during a new scene build, so we can close this for now. We can revisit if we run into performance issues on specific sites where this may be beneficial.

@gw3583 gw3583 closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.