Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support complex clipping regions with multiple nested rounded corner clipping regions #309

Closed
pcwalton opened this issue Jul 6, 2016 · 4 comments

Comments

@pcwalton
Copy link
Collaborator

@pcwalton pcwalton commented Jul 6, 2016

If you have the intersection of multiple nested border corners, we don't render that right. We need to.

@kvark
Copy link
Member

@kvark kvark commented Oct 31, 2016

I believe @glennw proposal to #498 will address this (pasting the relevant text from email here):

My idea is to remove that viewport_rect code, and introduce a new struct, which is a ClipRegionStack or something similar. As we traverse the tree in cull_layers() we would push the mask rect / transform into that as needed. This could return some kind of identifier for the clip region that applies to this part of the tree (perhaps store in the Layer structure?).

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Oct 31, 2016

@glennw
Copy link
Member

@glennw glennw commented Oct 31, 2016

@kvark Yes, the plan for the clip region stack we've discussed should cover this case too.

@glennw
Copy link
Member

@glennw glennw commented Jan 19, 2017

This happened. There are still some bugs and edge cases, but we can open specific issues for those as we encounter them.

@glennw glennw closed this Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.