Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrender does not build with stable rust #336

Closed
jrmuizel opened this issue Aug 10, 2016 · 9 comments
Closed

webrender does not build with stable rust #336

jrmuizel opened this issue Aug 10, 2016 · 9 comments

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Aug 10, 2016

We need this to able to put it in Gecko.
@emilio
Copy link
Member

@emilio emilio commented Aug 10, 2016

cc @nox, who did a tom of dependency work, how much work is needed for this?
@nox
Copy link
Member

@nox nox commented Aug 11, 2016

AFAICT the only thing needed is servo/ipc-channel@0e11b11, but that comes with the serde bump too, which depends on bumping hyper otherwise we get a serde split in servo. I can also just put that on an v0.4.x branch in ipc-channel if we are that hurried. WR and WR_traits themselves don't use fancy unstable features by default.
@nox
Copy link
Member

@nox nox commented Aug 11, 2016

Also for Gecko we probably need an implementation of ipc-channel for Windows that actually work. Cc @metajack @vvuk.
@drawoc drawoc mentioned this issue Oct 10, 2016
Merged
bors-servo added a commit that referenced this issue Oct 10, 2016
@bors-servo
Auto merge of #438 - drawoc:master, r=glennw
Loading status checks…
1a1da19 
Stop using step_by, which is unstable.

step_by on ranges isn't currently stable (see rust-lang/rust#27741), so stop using that function.

This is enough for webrender to compile on stable rust (1.12) on my machine, so it probably closes issue #336.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/438)
<!-- Reviewable:end -->
@drawoc
Copy link
Contributor

@drawoc drawoc commented Oct 13, 2016

Current master (6882420) builds on stable rust (1.12) for me.
@nox
Copy link
Member

@nox nox commented Oct 13, 2016

Did you try on Windows?
@drawoc
Copy link
Contributor

@drawoc drawoc commented Oct 13, 2016

Uh, no. I'm on 64-bit linux. I thought it might be worth noting that it builds on stable on at least one platform. I wouldn't know about windows.
@nox
Copy link
Member

@nox nox commented Oct 13, 2016

Yes it's definitely good news!
@glennw
Copy link
Member

@glennw glennw commented Oct 18, 2016

@nox Should we close this bug now, since I think WR itself builds on stable (we could open bugs in upstream dependencies if we need to)?
@nox
Copy link
Member

@nox nox commented Mar 4, 2017

NOT TRUE ANYMORE WOOOOOOOOOOOOOOO
@nox nox closed this Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@nox @jrmuizel @drawoc @emilio @glennw
You can’t perform that action at this time.