Add a RendererOption to configure if picture caching is enabled. #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although not hooked up internally yet, this provides a hook so that the gecko pref can be added. We'll use this to provide a temporary way to compare performance and also to allow picture caching to be disabled temporarily if we encounter any bad regressions.
|
r? @jrmuizel |
|
(or @kvark or anyone really) |
|
@gw3583 it would be great to have 3 options here: force-enabled, force-disabled, and manual (specified per-SC). Your words got stuck in my head about the fact that picture caching is going to hide some of our performance issues, and this is worrying me. So I'd like to be able to constantly run without it to see how good our baseline is. |
|
Discussed on IRC a bit. Anyhow, this is harmless. |
|
📌 Commit d2e4f4c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 30, 2018
Add a RendererOption to configure if picture caching is enabled. Although not hooked up internally yet, this provides a hook so that the gecko pref can be added. We'll use this to provide a temporary way to compare performance and also to allow picture caching to be disabled temporarily if we encounter any bad regressions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3367) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 1, 2018
…344a29b18678 (WR PR #3367). r=kats servo/webrender#3367 Differential Revision: https://phabricator.services.mozilla.com/D13554 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 1, 2018
…344a29b18678 (WR PR #3367). r=kats servo/webrender#3367 Differential Revision: https://phabricator.services.mozilla.com/D13554
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…344a29b18678 (WR PR #3367). r=kats servo/webrender#3367 Differential Revision: https://phabricator.services.mozilla.com/D13554 UltraBlame original commit: 5a212090eeecc702a8c3461e6926d9c83abb7c09
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…344a29b18678 (WR PR #3367). r=kats servo/webrender#3367 Differential Revision: https://phabricator.services.mozilla.com/D13554 UltraBlame original commit: 5a212090eeecc702a8c3461e6926d9c83abb7c09
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…344a29b18678 (WR PR #3367). r=kats servo/webrender#3367 Differential Revision: https://phabricator.services.mozilla.com/D13554 UltraBlame original commit: 5a212090eeecc702a8c3461e6926d9c83abb7c09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not hooked up internally yet, this provides a hook so
that the gecko pref can be added.
We'll use this to provide a temporary way to compare performance
and also to allow picture caching to be disabled temporarily if
we encounter any bad regressions.
This change is