Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashed borders should draw with a tight bounding rect. #3399

Closed
gw3583 opened this issue Dec 11, 2018 · 1 comment
Closed

Dashed borders should draw with a tight bounding rect. #3399

gw3583 opened this issue Dec 11, 2018 · 1 comment

Comments

@gw3583
Copy link
Contributor

gw3583 commented Dec 11, 2018

When dashes are drawn we draw vertices using the bounds of the corner rect. This results in a lot of overdraw for corners with a lot of dashes. This is generally not an issue since the corners are cached and the dash count / corner size is typically quite low.

However, in some Gecko reftests, the combination of the above with a software rasterizer, can make this take so long that it times out the reftest.

To fix it, we should use a tight bounding rect for the vertices around a dash in order to drastically reduce overdraw.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1510076 for more information.

@gw3583
Copy link
Contributor Author

gw3583 commented Feb 4, 2019

@nical fixed this.

@gw3583 gw3583 closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants