Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide access to a Fonts charmap #358

Closed
matprec opened this issue Aug 19, 2016 · 5 comments
Closed

Provide access to a Fonts charmap #358

matprec opened this issue Aug 19, 2016 · 5 comments

Comments

@matprec
Copy link
Contributor

@matprec matprec commented Aug 19, 2016

Beeing able to convert a character to the corresponding glyph is a rather useful thing. Wr employs Freetype on Windows&Linux, and Core graphics/text on Apple devices. Both of these font renderers support accessing the character map of a font, but Wr currently doesn't care.

The sole implementation is pretty simple, in FT this is basically one function call. You need to pass it through IPC and you'll have to deal with the Font Context thread pool / parallel execution.

The problem from my point of view is that i don't own an apple device and it therefore makes no sense that i'd create the corresponding apple implementation as i can't verify the implementation. I could provide the FT and API implementation, if someone could provide the core graphics implementation this should probably be ready to push.

I thought about Hackintosh / VM, but getting a legal os x iso is a pain in the apple.

If you can help out or want to share your thought, feel free to comment :)

@matprec
Copy link
Contributor Author

@matprec matprec commented Sep 6, 2016

I've now implemented it for freetype. It'd be awesome if someone could provide the mac part. Feel free to make a PR to my current repo. I'll create a PR to webrender/master when it's finished.

Edit: Fix typo

@randomPoison
Copy link
Contributor

@randomPoison randomPoison commented Jan 16, 2017

I'd like to help out on this one. I'll start on it on my own, but I don't have much experience with how fonts work so I'll likely have questions.

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 16, 2017

@MSleepyPanda What's the purpose of this API? I don't see why you'd want to ask webrender for this information instead of just getting it directly.

@matprec
Copy link
Contributor Author

@matprec matprec commented Jan 16, 2017

@jrmuizel Text layouting. At the time, i didn't knew about the difficulties of layouting and that there is much more involved. I thought of low memory foot print and that it would be more reasonable to access the existing font face instance (in webrender).
Now that i know about the complexity, i consider this to be out of the scope/not relevant for webrender itself.

@matprec matprec closed this Jan 16, 2017
@randomPoison
Copy link
Contributor

@randomPoison randomPoison commented Jan 16, 2017

👍 Coolio, less work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.