Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the bindings story for webrender #374

Closed
jrmuizel opened this issue Aug 26, 2016 · 8 comments
Closed

Figure out the bindings story for webrender #374

jrmuizel opened this issue Aug 26, 2016 · 8 comments

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Aug 26, 2016

We should figure out what we're going to do here. The simplest option that comes to mind is just maintaining hand written C bindings in the webrender repository. I'd be interested to hear what our other options are.

@metajack
Copy link

@metajack metajack commented Aug 26, 2016

One other option might be to just communicate with it via IPC? I suppose you'd still need enough bindings to start the main two threads.

We've typically planned to do this by having a maintained C entry point, but we've never had any real consumers so this hasn't gotten off the ground except for our CEF bindings. It's not hard to do, and you might look at the rust-url binding @valenting is working on for an example: https://github.com/valenting/rust-url-capi

@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented Sep 16, 2016

Looking around and thinking more, it seems like the best thing to do here is just wrap the webrender api in C. It seems like that should be more workable than trying to have C++ on one side of the ipc pipe as we don't need to worry about any of the serialization.

The webrender api seems reasonably amenable to wrapping in C.

@glennw
Copy link
Member

@glennw glennw commented Sep 16, 2016

I agree, this seems like the simplest option.

On 17/09/16 06:36, Jeff Muizelaar wrote:

Looking around and thinking more, it seems like the best thing to do
here is just wrap the webrender api in C. It seems like that should be
more workable than trying to have C++ on one side of the ipc pipe as
we don't need to worry about any of the serialization.

The webrender api seems reasonably amenable to wrapping in C.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#374 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACPfIrhw8wdxzAENOY4A3Bl-oWzV15n_ks5qqv21gaJpZM4JucW6.

@andreasgal
Copy link

@andreasgal andreasgal commented Oct 31, 2016

Did anyone sketch out yet what the C API would look like?

@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented Oct 31, 2016

Gecko is currently using https://github.com/jrmuizel/webrender/blob/bindings/webrender/webrender.h and https://github.com/jrmuizel/webrender/blob/bindings/webrender/src/bindings.rs

These are currently pretty incomplete but we're probably just going to iterate them toward what we need.

@glennw
Copy link
Member

@glennw glennw commented Jan 19, 2017

@jrmuizel Should we close this, unless there is something actionable that needs to be done here?

@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented Jan 19, 2017

@jrmuizel jrmuizel closed this Jan 19, 2017
@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented Apr 11, 2017

Our handwritten bindings are going to be replaced by the generator from here: https://github.com/jrmuizel/wr-binding/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.