Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for masking to images #405

Closed
jrmuizel opened this issue Sep 14, 2016 · 1 comment
Closed

Add support for masking to images #405

jrmuizel opened this issue Sep 14, 2016 · 1 comment

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Sep 14, 2016

This will be needed for SVG support, css mask-image and will be helpful for us in transitioning Gecko to webrender as we'll often have a mask image instead of the higher level primitive.

@kvark
Copy link
Member

@kvark kvark commented Oct 11, 2016

Looking into this

bors-servo added a commit that referenced this issue Oct 14, 2016
Shared clip source for the shaders

This will make it easier to introduce clipped primitives outside of the currently supported rectangles and images (related to #405). Also includes #443

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/444)
<!-- Reviewable:end -->
@jrmuizel jrmuizel mentioned this issue Oct 20, 2016
20 of 24 tasks complete
bors-servo added a commit that referenced this issue Oct 26, 2016
Image mask support

Closes #405

I'm not completely sure if this is the right approach, hoping to get some review/feedback to proceed. The API and logic works for me with `wr_sample`, although the implementation lacks a lot of features to support, like image repeating and layout transformations.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/445)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.