Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more sophisticated hit testing for scrolling touch action #411

Closed
jrmuizel opened this issue Sep 16, 2016 · 4 comments
Closed

Support more sophisticated hit testing for scrolling touch action #411

jrmuizel opened this issue Sep 16, 2016 · 4 comments

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Sep 16, 2016

The touch-action property along with event listeners require us to be able to hit test at a display item level.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action
@staktrace

@staktrace
Copy link
Contributor

@staktrace staktrace commented Aug 14, 2017

The bugzilla bug that is tracking this issue is https://bugzilla.mozilla.org/show_bug.cgi?id=1389149

@staktrace
Copy link
Contributor

@staktrace staktrace commented Aug 14, 2017

Note that I'm using this issue to specifically track putting touch-action/event listener info (together I refer to this as "event region info") into the WR display list. This also covers adding dummy display items where needed for content that is not user-visible but does affect hit-testing. Actually implementing the hit-test and exposing this information back out to the caller is covered by #1575.

@staktrace
Copy link
Contributor

@staktrace staktrace commented Nov 2, 2017

The changes in #1744 seem to be sufficient for what I wanted here. My plan is to use the u8 field in the ItemTag as a bitmask to store the touch-action information. We might need to expand it to a u16 later but for now a u8 should be ok. Closing this issue; the rest of the work is all gecko-side as far as I can tell.

@staktrace
Copy link
Contributor

@staktrace staktrace commented Nov 2, 2017

Oh, I can't actually close this issue. But somebody should.

@glennw glennw closed this Nov 2, 2017
@kvark kvark added the bugzilled label Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.