Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer / stacking context namining inconsistencies #496

Closed
glennw opened this issue Oct 28, 2016 · 3 comments
Closed

Fix layer / stacking context namining inconsistencies #496

glennw opened this issue Oct 28, 2016 · 3 comments

Comments

@glennw
Copy link
Member

@glennw glennw commented Oct 28, 2016

The use of layer as a term is inconsistent between the cpu and gpu portion of webrender. Very confusing...

@kvark
Copy link
Member

@kvark kvark commented Oct 28, 2016

Could be seen as a sub-task of #482

@nical
Copy link
Collaborator

@nical nical commented Nov 21, 2016

I propose using the "layer" terminology for the moving things that webrender bases its internal transforms on (like layers::Layer), and consistently use "stacking context" for things that map "1 to 1" to actual css stacking contexts.
Layers would be only scroll roots today, but if/when we are to support async animations and other fancy features, such elements would probably generate layers as well.

I'd appreciate if we wait for PR #568 to land before writing code for this to avoid ugly merge conflicts.

@glennw
Copy link
Member Author

@glennw glennw commented Nov 6, 2017

This can be considered complete with the removal of ClipScrollGroup and PackedLayer.

@glennw glennw closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.