Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushStackingContext has its own bounds field, instead of using common DisplayItem rect #619

Closed
vvuk opened this issue Dec 6, 2016 · 3 comments

Comments

@vvuk
Copy link
Contributor

@vvuk vvuk commented Dec 6, 2016

push_stacking_context sets DisplayItem::rect to Rect::zero() always, and has its own bounds inside StackingContext. I think this is a leftover from when SC's were converted to push/pop; we should be able to get rid of the inner bounds, right?

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Dec 7, 2016

@vvuk This seems reasonable to me.

@glennw
Copy link
Member

@glennw glennw commented Mar 31, 2017

@mrobinson Is this still relevant?

@mrobinson
Copy link
Member

@mrobinson mrobinson commented Mar 31, 2017

@glennw This shouldn't be an issue any longer because now stacking contexts just have a bounds and no longer a clip bounds as well. That bounds is stored in the common DisplayItem struct, so I'll just close this.

@mrobinson mrobinson closed this Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.