Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: No matching overload for function 'textureLod' found #628

Closed
mmatyas opened this issue Dec 12, 2016 · 5 comments
Closed

Error: No matching overload for function 'textureLod' found #628

mmatyas opened this issue Dec 12, 2016 · 5 comments

Comments

@mmatyas
Copy link
Contributor

@mmatyas mmatyas commented Dec 12, 2016

When running Servo on Android, the following shader compile error occurs (after applying the previous two Android patches, #626 and #627):

D/RustAndroidGlueStdouterr(22216): DEBUG:webrender::device: compile "ps_rectangle"
D/RustAndroidGlueStdouterr(22216): DEBUG:webrender::device: compile "ps_rectangle"
D/RustAndroidGlueStdouterr(22216): Failed to compile shader: "ps_rectangle"
D/RustAndroidGlueStdouterr(22216): WARN:servo: Panic hook called.
D/RustAndroidGlueStdouterr(22216): 0:715: S0001: No matching overload for function 'textureLod' found
D/RustAndroidGlueStdouterr(22216): ERROR:servo: -- Shader compile failed - exiting --

Here's the textureLod call. The problem occurs on an Odroid XU3, running Android 4.4.4.

Related: servo/servo#13154

@glennw
Copy link
Member

@glennw glennw commented Dec 12, 2016

That's interesting - as far as I can see textureLod is part of es3. @kvark We could change this to a texture(Offset) right? (even if just as a workaround for now).

@kvark
Copy link
Member

@kvark kvark commented Dec 12, 2016

Oh, I think we just need to pass 0.0 for the LOD (instead of 0), since it's a float parameter on all overloads of this function. @mmatyas would you be able to confirm if this is the right fix?

@glennw
Copy link
Member

@glennw glennw commented Dec 12, 2016

Ah, that makes sense.

@mmatyas
Copy link
Contributor Author

@mmatyas mmatyas commented Dec 12, 2016

Thanks; at the moment I don't have the Odroid at hand, but I will try it tomorrow (GMT+1).

@mmatyas
Copy link
Contributor Author

@mmatyas mmatyas commented Dec 13, 2016

Using 0.0 fixed the problem, thanks!

bors-servo added a commit that referenced this issue Dec 14, 2016
Fix `textureLod` parameter type

Fixes #628.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/632)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.