Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader error: `Keyword 'sample' is reserved` #634

Closed
mmatyas opened this issue Dec 13, 2016 · 0 comments
Closed

Shader error: `Keyword 'sample' is reserved` #634

mmatyas opened this issue Dec 13, 2016 · 0 comments

Comments

@mmatyas
Copy link
Contributor

@mmatyas mmatyas commented Dec 13, 2016

I've got the following error on Android, when I opened github.com in Servo, and tried to drag the scrollbar:

D/RustAndroidGlueStdouterr(30701): Failed to compile shader: "cs_blur"
D/RustAndroidGlueStdouterr(30701): 0:17: L0003: Keyword 'sample' is reserved
D/RustAndroidGlueStdouterr(30701): 0:18: L0001: Expected literal or '(', got 'sample'
D/RustAndroidGlueStdouterr(30701): 0:31: L0002: Undeclared variable 'color'
D/RustAndroidGlueStdouterr(30701): 0:32: L0002: Undeclared variable 'color'
D/RustAndroidGlueStdouterr(30701): 0:36: L0002: Undeclared variable 'color'
D/RustAndroidGlueStdouterr(30701): 0:38: L0002: Undeclared variable 'color'
D/RustAndroidGlueStdouterr(30701): ERROR:servo: -- Shader compile failed - exiting --

Here's line 18.

Related: servo/servo#13154
@kvark kvark mentioned this issue Dec 14, 2016
Merged
bors-servo added a commit that referenced this issue Dec 14, 2016
@bors-servo
Auto merge of #637 - kvark:sample, r=glennw
Loading status checks…
cf7c3c5 
Fixed the cs_blur 'sample' variable

Closes  #634

cc @mmatyas

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/637)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@mmatyas
You can’t perform that action at this time.