Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support source blending to the final framebuffer #643

Closed
kvark opened this issue Dec 14, 2016 · 8 comments
Closed

Support source blending to the final framebuffer #643

kvark opened this issue Dec 14, 2016 · 8 comments
Labels

Comments

@kvark
Copy link
Member

@kvark kvark commented Dec 14, 2016

https://bugzilla.mozilla.org/show_bug.cgi?id=1391322

See CAIRO_OPERATOR_SOURCE from https://www.cairographics.org/operators/

Not entirely sure this is needed. We may use this issue as a space for discussion and close it afterwards.
Gecko would provide us with a list of rectangles, which we would then need to ensure are not affected by any rendering. This can be done by rendering them with an opposite alpha from what our framebuffer is cleared with, right after the clear, and then compositing the otherwise final picture onto it with blending that excludes those areas.

@jrmuizel jrmuizel mentioned this issue Dec 14, 2016
20 of 24 tasks complete
@glennw
Copy link
Member

@glennw glennw commented Dec 14, 2016

Could you expand a little bit on the use case for this?

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Dec 15, 2016

This is used for making parts of the back buffer transparent for the vibrancy effect on OS X and cutting out the spots for window controls on Windows.

@glennw
Copy link
Member

@glennw glennw commented Dec 15, 2016

@jrmuizel Thanks - does this require anti-aliasing around the edges, or is it a straight in/out mask?

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Dec 15, 2016

I think pixel aligned rectangles are probably sufficient for our needs.

@glennw
Copy link
Member

@glennw glennw commented Dec 15, 2016

@jrmuizel OK - I wonder if it makes sense to just use the stencil buffer for this then?

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Dec 15, 2016

Possibly but that nearly feels like overkill. Let's look more closely at what an appropriate solution will be once we hook up the gecko side.

@glennw
Copy link
Member

@glennw glennw commented Dec 15, 2016

Sure, sounds good.

@kvark kvark added the bugzilled label Aug 17, 2017
@mstange
Copy link
Contributor

@mstange mstange commented Oct 25, 2017

This is superseded by #1926 and can be closed.

@glennw glennw closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.