Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with giant textures more gracefully than panicking #652

Closed
staktrace opened this issue Dec 15, 2016 · 3 comments
Closed

Deal with giant textures more gracefully than panicking #652

staktrace opened this issue Dec 15, 2016 · 3 comments

Comments

@staktrace
Copy link
Contributor

@staktrace staktrace commented Dec 15, 2016

There's a couple of gecko reftests that crash when run with WebRender because they fail the assertion at https://hg.mozilla.org/projects/graphics/file/73bdd29461ae/gfx/webrender/src/texture_cache.rs#l648. We should handle that scenario more gracefully. Mozilla bug for this issue is https://bugzilla.mozilla.org/show_bug.cgi?id=1322816

@nical
Copy link
Collaborator

@nical nical commented Dec 20, 2016

I started looking into this.

The approach I am taking is to split the large image into smaller tiles, upload the ones that are visible on screen to the texture cache and generate a primitive for each visible tile instead of just one for the image.

@glennw
Copy link
Member

@glennw glennw commented Mar 21, 2017

@nical I think this can be closed now?

@nical
Copy link
Collaborator

@nical nical commented Mar 21, 2017

Yes \o/

@KiChjang KiChjang closed this Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.