Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsupport external "image buffer" in Webrender #723
Closed
Labels
Comments
|
So there is going to be at least 3 ways to provide the texture contents:
|
|
Yes, there will have 3 different ways to set the texture to WR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@glennw @nical @kvark
Currently, webrender could resolve a gl texture id from a external texture id through the externalImage callback api[1]. Then, webrender could use that gl texture id for rendering.
I think we could also pass raw buffer to webrender, and let webrender to upload this buffer into gl texture. In this way, webrender might use texture atlas for this texture uploading. That could have a better performance in drawing with batching.
We can't just use the wr_add_image() api directly, that api implies some memory copy operations. That's not a good practice for a large image.
I will attach my patch here if I fix the crash in my WIP.
[1]
1cb9ab2