Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample not displaying correctly on Hi DPI display #725

Closed
randomPoison opened this issue Jan 16, 2017 · 4 comments
Closed

Sample not displaying correctly on Hi DPI display #725

randomPoison opened this issue Jan 16, 2017 · 4 comments

Comments

@randomPoison
Copy link
Contributor

@randomPoison randomPoison commented Jan 16, 2017

When I run wr-sample on my MacBook Pro this is how it looks:

screen shot 2017-01-16 at 3 50 35 pm

Everything but the background seems to be limited to a quarter of the screen, and the hidpi factor for my display is 2, so it looks like webrender isn't taking the hidpi scaling factor into account.

System Info

  • MackBook Pro (Retina, 15-inch, Mid 2015)
  • OS X EL Capitan (Version 10.11.6)
  • OpenGL version 4.1 INTEL-10.14.73, Intel Iris Pro OpenGL Engine
  • hidpi factor: 2 (native 2)
  • webrender version 0.11.1
@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 16, 2017

I see this as well. I think this might be fixed by calling glViewport with actual size in pixels of the window.
@glennw glennw mentioned this issue Feb 28, 2017
Merged
@waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Mar 30, 2017

@glennw thought this might be fixed by his change in #935, but I'm still seeing this problem today after checking out master and running on a Retina MBP.
@glennw
Copy link
Member

@glennw glennw commented Mar 30, 2017

@waywardmonkeys Hmm, I thought that would fix it too. Unfortunately I don't have a retina MBP here to test with or debug.
waywardmonkeys added a commit to waywardmonkeys/webrender that referenced this issue Apr 7, 2017
@waywardmonkeys
Sample now uses full window on Retina display on macOS.
81dbcd5 
Using the number of pixels gives us the correct device size.

Fixes issue servo#725.
@waywardmonkeys waywardmonkeys mentioned this issue Apr 7, 2017
Merged
bors-servo added a commit that referenced this issue Apr 7, 2017
@bors-servo
Auto merge of #1081 - waywardmonkeys:improve-retina-sample, r=kvark
Loading status checks…
31cbe69 
Sample now uses full window on Retina display on macOS.

Using the number of pixels gives us the correct device size.

Fixes issue #725.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1081)
<!-- Reviewable:end -->
@glennw
Copy link
Member

@glennw glennw commented Sep 4, 2017

This is resolved by #1081.
@glennw glennw closed this Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@waywardmonkeys @jrmuizel @randomPoison @glennw
You can’t perform that action at this time.