Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rectangle clips don't apply to nested stacking contexts #735

Closed
jrmuizel opened this issue Jan 18, 2017 · 1 comment
Closed

rectangle clips don't apply to nested stacking contexts #735

jrmuizel opened this issue Jan 18, 2017 · 1 comment
Assignees

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Jan 18, 2017

The following yaml file draws incorrectly. We should not see a 100x100 box.

---
root:
  items:
    - 
      type: stacking_context
      bounds: [0, 0, 95, 88]
      clip:
        rect: [9, 9, 10, 10]
      items:
        - 
          type: stacking_context
          bounds: [0, 0, 95, 88]
          clip:
              rect: [0, 0, 100, 100]
          items:
            - 
              bounds: [0, 0, 100, 100]
              type: rect
              color: blue
@glennw
Copy link
Member

@glennw glennw commented Jan 18, 2017

The clip mask code only considers the complex part of the clip region. We need to consider the main clip rect itself too - perhaps generate a mask when not axis-aligned, and have a fast path otherwise.

@kvark kvark self-assigned this Jan 19, 2017
bors-servo added a commit that referenced this issue Jan 30, 2017
Include the clipping rectangle of a stacking context into the clip stack

Fixes #735
r? @glennw
(please don't merge until I confirm that servo tests are good)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/763)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 30, 2017
Include the clipping rectangle of a stacking context into the clip stack

Fixes #735
r? @glennw
(please don't merge until I confirm that servo tests are good)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/763)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 31, 2017
Include the clipping rectangle of a stacking context into the clip stack

Fixes #735
r? @glennw
(please don't merge until I confirm that servo tests are good)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/763)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.