Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement preserve-3d #739
Closed
Comments
Closed
|
Me and @mrobinson are interested to implement this. |
|
Got https://github.com/kvark/plane-split, going to try hooking it up to WR next. |
|
The license should probably at least be dual with MPL2 |
|
Some observations from looking into this:
|
bors-servo
added a commit
that referenced
this issue
May 1, 2017
Basic preserve-3d support Goes towards #739 This is a basic implementation that features a green test case. It can be merged independently, but more work is expected to solidify it. There is a lot of interaction of "preserve3d" stacking contexts with filters, composite ops, and such, that is not thought-through or tested at the moment. The new code should be totally safe as long as the client continues to use `TransformStyle::Flat` (as both Gecko/Servo still do). r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1169) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 8, 2017
Better Preserve3D support Follow up to #1169 Includes #1207 r? @glennw @mrobinson - "preserve-3d" only affects children stacking contexts and contained items - generated polygon coordinates of non-zero local bounds - sorting order The Servo PR is being [worked on](servo/servo@master...kvark:preserve3d), but it's not required here, since it may safely continue using `TransformStyle::Flat`. There is at least one feature on the horizon to be implemented before #739 can be truly closed. The `TransformStyle` should be moved out of the stacking context and deserve it's own pushable item (similar to clip-scroll groups). This is required because an item without "preserve-3d" automatically becomes "flat" but does not establish a stacking context, which is [tested by Servo](https://raw.githubusercontent.com/servo/servo/master/tests/wpt/css-tests/css-transforms-1_dev/html/transform3d-sorting-004.htm). Edit: apparently, Chrome disagrees here, so the current approach of WR might stay. Create Bugstar [issue-1362543](https://bugzilla.mozilla.org/show_bug.cgi?id=1362543). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1208) <!-- Reviewable:end -->
|
preserve-3d support has merged. Let's close this and open new issues for any specific bugs / missing features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The basic plan is to use a bsp tree to do plane-splitting like Gecko does.
It probably makes the most sense for this work to wait for the work in #742