Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic in handle_primitive_run #894

Closed
jrmuizel opened this issue Feb 17, 2017 · 2 comments
Closed

panic in handle_primitive_run #894

jrmuizel opened this issue Feb 17, 2017 · 2 comments

Comments

@jrmuizel
Copy link
Contributor

@jrmuizel jrmuizel commented Feb 17, 2017

http://people.mozilla.com/~jmuizelaar/tmp/scroll-frame-crash.zip panics at
https://github.com/servo/webrender/blob/master/webrender/src/frame_builder.rs#L1194

cc @mrobinson
@glennw
Copy link
Member

@glennw glennw commented Feb 17, 2017

@jrmuizel says this isn't super urgent, as the failing tests can be disabled for now.
@jrmuizel
Copy link
Contributor Author

@jrmuizel jrmuizel commented Feb 17, 2017

This was discovered here: https://bugzilla.mozilla.org/show_bug.cgi?id=1332688
mrobinson added a commit to mrobinson/webrender that referenced this issue Feb 20, 2017
@mrobinson
Properly handle content transformed to empty rect
a35027f 
When content was transformed to an empty rectangle, we didn't always
make its ClipScrollGroup xf_rect member None. This caused an issue when
we tried to use the xf_rect member of the ScrollLayer for masking,
which was properly set to None. We fix this issue by making the
behavior consistent between the two structs.

Fixes servo#894.
@mrobinson mrobinson mentioned this issue Feb 20, 2017
Merged
bors-servo added a commit that referenced this issue Feb 21, 2017
@bors-servo
Auto merge of #905 - mrobinson:fix-empty-mask, r=glennw
Loading status checks…
92fd6a7 
Properly handle content transformed to empty rect

When content was transformed to an empty rectangle, we didn't always
make its ClipScrollGroup xf_rect member None. This caused an issue when
we tried to use the xf_rect member of the ScrollLayer for masking,
which was properly set to None. We fix this issue by making the
behavior consistent between the two structs.

Fixes #894.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/905)
<!-- Reviewable:end -->
nical added a commit to nical/webrender that referenced this issue Feb 21, 2017
@mrobinson @nical
Properly handle content transformed to empty rect
e52cf4a 
When content was transformed to an empty rectangle, we didn't always
make its ClipScrollGroup xf_rect member None. This caused an issue when
we tried to use the xf_rect member of the ScrollLayer for masking,
which was properly set to None. We fix this issue by making the
behavior consistent between the two structs.

Fixes servo#894.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Properly handle content transformed to empty rect
2 participants
@jrmuizel @glennw
You can’t perform that action at this time.