Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDebug WR builds panic on shutdown due to Renderer::drop #915
Assignees
Comments
|
cc @kvark |
|
oops, that was a last-minute change. Looking now |
This was referenced Feb 22, 2017
Merged
bors-servo
added a commit
that referenced
this issue
Feb 22, 2017
Renderer::deinit Fixes #915 r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/916) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Feb 23, 2017
Refactored input handling in sample & wrench After missing #915 due to being unable to escape the sample with "Esc", I figured this could be improved ;) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/917) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=79439278&repo=try&lineNumber=1723
The drop implementation added to Renderer in #913 tries to call deinit_texture, but that function has a debug assertion that
self.inside_frameis true. Which it isn't, when drop() is called.This blocks updating WR in the graphics branch as all the debug test jobs will crash.