Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplitting the clipped rectangles into opaque/transparent sub-parts #1005
Conversation
|
Nice simple change! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 23, 2017
Splitting the clipped rectangles into opaque/transparent sub-parts This is a simple optimization targeted at the case of large rectangles with rounded cornered clips. Instead of moving it into the transparent bin and rendering late, we are computing the inner intersection of the clip items and splitting the rectangle into opaque/transparent parts. On my machine, this reduces the GPU time of https://github.com/servo/servo by approximately 10%: from 4.6ms to 3.9ms. More profiling might be needed, especially on windows. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1005) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 6, 2017
Inner rectangle compute refactor This should be cleaner and a bit faster w.r.t the transparency optimization of #1005 r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1076) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedMar 23, 2017
•
edited by larsbergstrom
This is a simple optimization targeted at the case of large rectangles with rounded cornered clips. Instead of moving it into the transparent bin and rendering late, we are computing the inner intersection of the clip items and splitting the rectangle into opaque/transparent parts.
On my machine, this reduces the GPU time of https://github.com/servo/servo by approximately 10%: from 4.6ms to 3.9ms. More profiling might be needed, especially on windows.
r? @glennw
This change is