Tile external buffer images when they exceed the maximum texture size. #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much better, thanks! |
|
📌 Commit b556ba8 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #997) made this pull request unmergeable. Please resolve the merge conflicts. |
nical
force-pushed
the
tiled-external-buffer
branch
from
b556ba8 to
16743c5
Compare
|
Rebased. It doesn't read as nicely anymore due to the verbosity of ExternalImageData. I am tempted to change ImageData::External to be |
kvark
approved these changes
Mar 30, 2017
webrender/src/resource_cache.rs
Outdated
| &ImageData::Raw(_) => { size_check } | ||
| &ImageData::Blob(_) => { size_check } | ||
| &ImageData::External(ExternalImageData { image_type: ExternalImageType::ExternalBuffer, .. }) => { | ||
| size_check |
There was a problem hiding this comment.
nit: could do data.image_type == ExternalImageType::ExternalBuffer && size_check instead of pattern matching
nical
force-pushed
the
tiled-external-buffer
branch
2 times, most recently
from
38b789e to
97cdf3e
Compare
nical
force-pushed
the
tiled-external-buffer
branch
from
97cdf3e to
48d7c6a
Compare
|
@bors-servo r+ |
|
📌 Commit 48d7c6a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 30, 2017
Tile external buffer images when they exceed the maximum texture size. Fixes issue #1027, and addresses a review comment from PR #1004 about explicitly enumerating all variants instead of using ```_ => { ... }``` in this match expression. r? @kvark <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1036) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1027, and addresses a review comment from PR #1004 about explicitly enumerating all variants instead of using
_ => { ... }in this match expression.r? @kvark
This change is