Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTile external buffer images when they exceed the maximum texture size. #1036
Conversation
|
Much better, thanks! |
|
|
|
|
|
|
|
Rebased. It doesn't read as nicely anymore due to the verbosity of ExternalImageData. I am tempted to change ImageData::External to be |
| &ImageData::Raw(_) => { size_check } | ||
| &ImageData::Blob(_) => { size_check } | ||
| &ImageData::External(ExternalImageData { image_type: ExternalImageType::ExternalBuffer, .. }) => { | ||
| size_check |
This comment has been minimized.
This comment has been minimized.
kvark
Mar 30, 2017
•
Member
nit: could do data.image_type == ExternalImageType::ExternalBuffer && size_check instead of pattern matching
nical
force-pushed the
nical:tiled-external-buffer
branch
2 times, most recently
from
38b789e
to
97cdf3e
|
@bors-servo r+ |
|
|
Tile external buffer images when they exceed the maximum texture size. Fixes issue #1027, and addresses a review comment from PR #1004 about explicitly enumerating all variants instead of using ```_ => { ... }``` in this match expression. r? @kvark <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1036) <!-- Reviewable:end -->
|
|
nical commentedMar 30, 2017
•
edited by larsbergstrom
Fixes issue #1027, and addresses a review comment from PR #1004 about explicitly enumerating all variants instead of using
_ => { ... }in this match expression.r? @kvark
This change is