Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable dither on gradients, so we can update WR. #1042

Merged
merged 1 commit into from Mar 31, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Temporarily disable dither on gradients, so we can update WR.

There are a number of WPT/CSS tests that break with the current
gradient dither code. For now, disable dither on gradients so that
we can land a WR update in Servo. We can re-enable the dither
once the reftest bug is fixed.
  • Loading branch information
gw3583 committed Mar 31, 2017
commit 8d46372a51ffcec27e9fe7d6f00d1caf22681996
@@ -12,5 +12,9 @@ void main(void) {
#endif

alpha = min(alpha, do_clip());
oFragColor = dither(vColor * vec4(1.0, 1.0, 1.0, alpha));

// TODO(gw): Re-enable the gradient dither once we get the
// reftests passing.
//oFragColor = dither(vColor * vec4(1.0, 1.0, 1.0, alpha));
oFragColor = vColor * vec4(1.0, 1.0, 1.0, alpha);
}
@@ -2,9 +2,9 @@
== premultiplied-angle.yaml blank.yaml
== premultiplied-radial.yaml blank.yaml

== linear.yaml linear-ref.png
== linear-reverse.yaml linear-ref.png
fuzzy(1,300) == linear-stops.yaml linear-stops-ref.png
fuzzy(1,20000) == linear.yaml linear-ref.png
fuzzy(1,20000) == linear-reverse.yaml linear-ref.png
fuzzy(1,29300) == linear-stops.yaml linear-stops-ref.png

# dithering requires us to fuzz here
fuzzy(1,20000) == linear.yaml linear-ref.yaml
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.