Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper dither re-enabled #1045

Merged
merged 4 commits into from Apr 3, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Revert "Temporarily disable dither on gradients, so we can update WR."

This reverts commit 8d46372.
  • Loading branch information
kvark committed Mar 31, 2017
commit d5280ec8551ad4387980bca8517e78dc501fd518
@@ -12,9 +12,5 @@ void main(void) {
#endif

alpha = min(alpha, do_clip());

// TODO(gw): Re-enable the gradient dither once we get the
// reftests passing.
//oFragColor = dither(vColor * vec4(1.0, 1.0, 1.0, alpha));
oFragColor = vColor * vec4(1.0, 1.0, 1.0, alpha);
oFragColor = dither(vColor * vec4(1.0, 1.0, 1.0, alpha));
}
@@ -2,9 +2,9 @@
== premultiplied-angle.yaml blank.yaml
== premultiplied-radial.yaml blank.yaml

fuzzy(1,20000) == linear.yaml linear-ref.png
fuzzy(1,20000) == linear-reverse.yaml linear-ref.png
fuzzy(1,29300) == linear-stops.yaml linear-stops-ref.png
== linear.yaml linear-ref.png
== linear-reverse.yaml linear-ref.png
fuzzy(1,300) == linear-stops.yaml linear-stops-ref.png

# dithering requires us to fuzz here
fuzzy(1,20000) == linear.yaml linear-ref.yaml
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.