Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement partial support for `box-shadow` and add support for clipping out (rectangle subtraction) to the clipper. #11
Conversation
out (rectangle subtraction) to the clipper. Known issues: * Clipping out does not clip the uv coordinates properly. * Clipping to rounded rectangle corners does not work yet. * Box shadows with elliptical radii are unsupported (also in master Servo). * Box shadows with heterogeneous radii for each corner are unsupported (also in master Servo). This PR depends on some changes to Servo to support the new border radius field in box shadow display items: servo/servo#7896
| let t1 = precise_time_ns(); | ||
| let ms = (t1 - self.t0) as f64 / 1000000f64; | ||
| //if ms > 0.1 { | ||
| if self.name.chars().next() != Some(' ') { |
This comment has been minimized.
This comment has been minimized.
|
@pcwalton Nice, looks fairly straight forward. Just the one question / change above, then I'll merge it. |
| }; | ||
|
|
||
| // FIXME(pcwalton): Clip the u and v too. | ||
| let mut result = vec![]; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Manishearth
Oct 6, 2015
Member
(My clipping PR has some reusable buffers that could be used here to be even more efficient)
glennw
added a commit
that referenced
this pull request
Oct 7, 2015
Implement partial support for `box-shadow` and add support for clipping out (rectangle subtraction) to the clipper.
nox
pushed a commit
to nox/webrender
that referenced
this pull request
Aug 6, 2016
Setup continuous integration with Travis CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 6, 2015
Known issues:
Servo).
(also in master Servo).
This PR depends on some changes to Servo to support the new border
radius field in box shadow display items: servo/servo#7896
r? @glennw