Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid overflowing indices in batches. #111
Merged
Conversation
This switches WebRender to use a u32 index internally for batches and to generate new batches when a u16 overflow would occur. Indices are still truncated to u16 before sending the batches to OpenGL.
glennw
added a commit
that referenced
this pull request
Dec 5, 2015
Avoid overflowing indices in batches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedDec 4, 2015
This switches WebRender to use a u32 index internally for batches and to
generate new batches when a u16 overflow would occur. Indices are still
truncated to u16 before sending the batches to OpenGL.