Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix combined_local_viewport_rect for nested nodes #1114
Merged
Conversation
The calculation of the combined_local_viewport_rect was being done using the accumulated_scroll_offset, but this was not correct, because the parent combined_local_viewport_rect was already calculated to be independent of those offsets. This means that the only scrolling offset that matters is one between the parent and the child. Add a test for this as well.
|
Looks good! Just one question there |
| NodeType::Clip(_) => { | ||
| (*parent_reference_frame_transform, | ||
| parent_accumulated_scroll_offset + node.scrolling.offset) | ||
| node.scrolling.offset, | ||
| node.scrolling.offset + parent_accumulated_scroll_offset) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
Apr 13, 2017
Author
Member
The parent_accumulated_scroll_offset is used to setup the content and viewport transformation for each node. In those cases we do need to take into account the combined scroll offsets.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 13, 2017
…kvark Fix combined_local_viewport_rect for nested nodes The calculation of the combined_local_viewport_rect was being done using the accumulated_scroll_offset, but this was not correct, because the parent combined_local_viewport_rect was already calculated to be independent of those offsets. This means that the only scrolling offset that matters is one between the parent and the child. Add a test for this as well. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1114) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedApr 13, 2017
•
edited by larsbergstrom
The calculation of the combined_local_viewport_rect was being done
using the accumulated_scroll_offset, but this was not correct, because
the parent combined_local_viewport_rect was already calculated to be
independent of those offsets. This means that the only scrolling offset
that matters is one between the parent and the child.
Add a test for this as well.
This change is