New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct for empty box shadow rects #1117
Merged
+27
−1
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
| @@ -786,9 +786,13 @@ impl FrameBuilder { | ||
|
|
||
| let bs_rect = box_bounds.translate(box_offset) | ||
| .inflate(inflate_amount, inflate_amount); | ||
| // If we have negative inflate amounts. | ||
| // Have to explicitly check this since euclid::TypedRect relies on negative rects | ||
| let bs_rect_empty = bs_rect.size.width <= 0.0 || bs_rect.size.height <= 0.0; | ||
changm
Author
Contributor
|
||
|
|
||
| // Just draw a rectangle | ||
| if blur_radius == 0.0 && spread_radius == 0.0 && clip_mode == BoxShadowClipMode::None { | ||
| if (blur_radius == 0.0 && spread_radius == 0.0 && clip_mode == BoxShadowClipMode::None) | ||
| || bs_rect_empty { | ||
| self.add_solid_rectangle(clip_id, | ||
| box_bounds, | ||
| clip_region, | ||
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| root: | ||
| items: | ||
| - type: stacking-context | ||
| bounds: [50, 50, 100, 100] | ||
| items: | ||
| - type: rect | ||
| bounds: [ 10, 10, 80, 80 ] | ||
| color: [255, 0, 0] |
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| root: | ||
| items: | ||
| - type: stacking-context | ||
| bounds: [50, 50, 100, 100] | ||
| items: | ||
| - type: box-shadow | ||
| bounds: [ 10, 10, 80, 80 ] | ||
| blur-radius: 5 | ||
| clip-mode: inset | ||
| spread-radius: 200 | ||
| color: [255, 0, 0] |
| @@ -1,6 +1,7 @@ | ||
| != inset-simple.yaml inset-simple-ref.yaml | ||
| != inset-spread.yaml inset-spread-ref.yaml | ||
| == inset-no-blur-radius.yaml inset-no-blur-radius-ref.png | ||
| == inset-spread-large.yaml inset-spread-large-ref.yaml | ||
|
|
||
| # fuzzy because the test is a blur. Just want to test that clip out works. | ||
| fuzzy(7,13704) == inset-border-radius.yaml inset-border-radius-ref.yaml |
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
should the conditions be
<instead of<=, given the comment says "negative"?