Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement GetShaderPrecisionFormat WebGL command #1127
Conversation
|
Looks good! |
b95d360
to
112af22
|
@kvark yes, version bumped :) |
|
Thanks! |
|
|
Implement GetShaderPrecisionFormat WebGL command Implement GetShaderPrecisionFormat. See servo/gleam#119 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1127) <!-- Reviewable:end -->
|
|
|
Note:
I don't know enough about the vendoring process to know if this is normal/expected, so I'm just posting this here so it's recorded somewhere persistent! |
|
I think the |
…tajack Implement WebGL::GetShaderPrecisionFormat <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16544) <!-- Reviewable:end -->
Implement WebGL::GetShaderPrecisionFormat <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13985 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16544) <!-- Reviewable:end -->
… MortimerGoro:get_shader_precision_format); r=jdm <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13985 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 639cc715b13e2ef0d2a920e53b8c055933bed73a
… MortimerGoro:get_shader_precision_format); r=jdm <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13985 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
… MortimerGoro:get_shader_precision_format); r=jdm <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13985 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
… MortimerGoro:get_shader_precision_format); r=jdm <!-- Please describe your changes on the following line: --> Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13985 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
MortimerGoro commentedApr 17, 2017
•
edited
Implement GetShaderPrecisionFormat. See servo/gleam#119
This change is