Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetShaderPrecisionFormat WebGL command #1127

Merged
merged 1 commit into from Apr 17, 2017

Conversation

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Apr 17, 2017

Implement GetShaderPrecisionFormat. See servo/gleam#119

This change is Reviewable

@kvark
kvark approved these changes Apr 17, 2017
Copy link
Member

kvark left a comment

Looks good!
I suppose it needs a minor version bump.

@MortimerGoro MortimerGoro force-pushed the MortimerGoro:get_shader_precision branch from b95d360 to 112af22 Apr 17, 2017
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Apr 17, 2017

@kvark yes, version bumped :)

@kvark
Copy link
Member

kvark commented Apr 17, 2017

Thanks!
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2017

📌 Commit 112af22 has been approved by kvark

bors-servo added a commit that referenced this pull request Apr 17, 2017
Implement GetShaderPrecisionFormat WebGL command

Implement GetShaderPrecisionFormat. See servo/gleam#119
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1127)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2017

Testing commit 112af22 with merge 1c59cd6...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 17, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 1c59cd6 to master...

@bors-servo bors-servo merged commit 112af22 into servo:master Apr 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Gankra
Copy link
Contributor

Gankra commented Apr 18, 2017

Note: mach vendor rust in Firefox seems to vomit while processing this gleam update -- specifically when it hits gkrust.

/Users/ABeingessner/.cargo/bin/cargo update --manifest-path /Users/ABeingessner/dev/firefox/src/mozilla-central/toolkit/library/rust/Cargo.toml -p gkrust
Error running mach:

    ['vendor', 'rust']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 101: ['/Users/ABeingessner/.cargo/bin/cargo', u'update', u'--manifest-path', u'/Users/ABeingessner/dev/firefox/src/mozilla-central/toolkit/library/rust/Cargo.toml', u'-p', u'gkrust']

  File "/Users/ABeingessner/dev/firefox/src/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 1805, in vendor_rust
    vendor_command.vendor(**kwargs)
  File "/Users/ABeingessner/dev/firefox/src/mozilla-central/python/mozbuild/mozbuild/vendor_rust.py", line 275, in vendor
    self._run_command_in_srcdir(args=[cargo, 'update', '--manifest-path', mozpath.join(path, 'Cargo.toml'), '-p', lib])
  File "/Users/ABeingessner/dev/firefox/src/mozilla-central/python/mozbuild/mozbuild/base.py", line 600, in _run_command_in_srcdir
    return self.run_process(cwd=self.topsrcdir, **args)
  File "/Users/ABeingessner/dev/firefox/src/mozilla-central/python/mach/mach/mixin/process.py", line 147, in run_process
    raise Exception('Process executed with non-0 exit code %d: %s' % (status, args))

I don't know enough about the vendoring process to know if this is normal/expected, so I'm just posting this here so it's recorded somewhere persistent!

@staktrace
Copy link
Contributor

staktrace commented Apr 18, 2017

I think the mach vendor rust problem is a result of limitations in the cargo update command and our vendoring process. I'm not sure of what a proper fix would be, but for now what I'm going to suggest is to run cargo update -p webrender_traits -p gleam in both toolkit/library/rust and toolkit/library/gtest/rust before running mach vendor rust. That should fix it for you locally, and I'll try to figure out how to fix it more properly.

bors-servo added a commit to servo/servo that referenced this pull request Apr 20, 2017
…tajack

Implement WebGL::GetShaderPrecisionFormat

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16544)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Apr 21, 2017
Implement WebGL::GetShaderPrecisionFormat

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13985 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16544)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 22, 2017
… MortimerGoro:get_shader_precision_format); r=jdm

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13985 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 639cc715b13e2ef0d2a920e53b8c055933bed73a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 1, 2019
… MortimerGoro:get_shader_precision_format); r=jdm

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13985 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a

UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 1, 2019
… MortimerGoro:get_shader_precision_format); r=jdm

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13985 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a

UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 1, 2019
… MortimerGoro:get_shader_precision_format); r=jdm

<!-- Please describe your changes on the following line: -->

Implement WebGL::GetShaderPrecisionFormat. See servo/gleam#119 && servo/webrender#1127

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13985 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 1661ae6cf40df574853a822164d36f8d791c646a

UltraBlame original commit: 3a2d495b4d280f1c59f3bd48b252786ead4ff9a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.