Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused z-index parameter #1155
Conversation
|
I've also not found any use of it in WR so far. |
|
@bors-servo r+ |
|
|
Remove unused z-index parameter This isn't used anywhere inside WebRender and who knows what the semantics would be. Servo and Gecko both z-sort before creating WebRender display lists. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
Remove unused z-index parameter This isn't used anywhere inside WebRender and who knows what the semantics would be. Servo and Gecko both z-sort before creating WebRender display lists. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155) <!-- Reviewable:end -->
|
|
|
We seem to be hitting some kind of timeout on the mac builder permanently with all the pending PRs. Any suggestions @metajack @larsbergstrom ? Perhaps we could try updating the rustc version? |
|
It looks like this pull request succeeded: #1158 |
|
Yeah, it looks like there's something going on:
A 10 minute pause without any output from rustc or it completing seems not unusal, though, considering that even though the build is fast on debug:
Looking at a successful build on release, it did take 21.95 minutes:
I suspect that you should either send mail to support@travis-ci.org to ask them to increase the timeout slightly or use one of the wrappers: That said, ~22 minutes seems like a REALLY long time to compile just webrender. Is there something going on here, maybe? Or a compiler regression? |
|
|
|
Other PRs have been getting through today, so maybe it was a travis issue? Let's just retry this once it's rebased. |
This isn't used anywhere inside WebRender and who knows what the semantics would be. Servo and Gecko both z-sort before creating WebRender display lists.
|
Retrying... |
|
|
Remove unused z-index parameter This isn't used anywhere inside WebRender and who knows what the semantics would be. Servo and Gecko both z-sort before creating WebRender display lists. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155) <!-- Reviewable:end -->
|
|
jrmuizel commentedApr 21, 2017
•
edited by larsbergstrom
This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.
This change is