Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused z-index parameter #1155

Merged
merged 1 commit into from Apr 25, 2017
Merged

Remove unused z-index parameter #1155

merged 1 commit into from Apr 25, 2017

Conversation

@jrmuizel
Copy link
Contributor

jrmuizel commented Apr 21, 2017

This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.


This change is Reviewable

@kvark
Copy link
Member

kvark commented Apr 22, 2017

I've also not found any use of it in WR so far.
Leaving for @glennw to have a look.

@glennw
Copy link
Member

glennw commented Apr 23, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

📌 Commit 97b605a has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

Testing commit 97b605a with merge 4c0f3bf...

bors-servo added a commit that referenced this pull request Apr 23, 2017
Remove unused z-index parameter

This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2017

💔 Test failed - status-travis

@glennw
Copy link
Member

glennw commented Apr 24, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

Testing commit 97b605a with merge 70ca467...

bors-servo added a commit that referenced this pull request Apr 24, 2017
Remove unused z-index parameter

This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

💔 Test failed - status-travis

@glennw
Copy link
Member

glennw commented Apr 24, 2017

We seem to be hitting some kind of timeout on the mac builder permanently with all the pending PRs. Any suggestions @metajack @larsbergstrom ? Perhaps we could try updating the rustc version?

@jrmuizel
Copy link
Contributor Author

jrmuizel commented Apr 24, 2017

It looks like this pull request succeeded: #1158

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Apr 24, 2017

Yeah, it looks like there's something going on:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

A 10 minute pause without any output from rustc or it completing seems not unusal, though, considering that even though the build is fast on debug:

Finished dev [unoptimized + debuginfo] target(s) in 49.80 secs

Looking at a successful build on release, it did take 21.95 minutes:

Finished release [optimized + debuginfo] target(s) in 1317.76 secs

I suspect that you should either send mail to support@travis-ci.org to ask them to increase the timeout slightly or use one of the wrappers:
https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

That said, ~22 minutes seems like a REALLY long time to compile just webrender. Is there something going on here, maybe? Or a compiler regression?

@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2017

The latest upstream changes (presumably #1160) made this pull request unmergeable. Please resolve the merge conflicts.

@glennw
Copy link
Member

glennw commented Apr 24, 2017

Other PRs have been getting through today, so maybe it was a travis issue? Let's just retry this once it's rebased.

@jrmuizel jrmuizel force-pushed the jrmuizel:z-index branch from 97b605a to 7cb1c2b Apr 24, 2017
This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.
@jrmuizel jrmuizel force-pushed the jrmuizel:z-index branch from 7cb1c2b to c872232 Apr 24, 2017
@kvark
Copy link
Member

kvark commented Apr 25, 2017

Retrying...
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

📌 Commit c872232 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

Testing commit c872232 with merge 5a4c337...

bors-servo added a commit that referenced this pull request Apr 25, 2017
Remove unused z-index parameter

This isn't used anywhere inside WebRender and who knows what the
semantics would be. Servo and Gecko both z-sort before creating
WebRender display lists.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1155)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 25, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 5a4c337 to master...

@bors-servo bors-servo merged commit c872232 into servo:master Apr 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.