Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a feature for dithering #1172
Merged
Conversation
|
I think it's reasonable to have it feature gated. |
webrender/res/prim_shared.glsl
Outdated
| @@ -837,4 +838,6 @@ vec4 dither(vec4 color) { | |||
|
|
|||
| return color + vec4(noise, noise, noise, 0); | |||
| } | |||
| #endif | |||
This comment has been minimized.
This comment has been minimized.
kvark
Apr 27, 2017
Member
I believe all you need on the shader side is
#else
vec4 dither(vec4 color) { return color; }
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
|
|
|
This needs a rebase, then should be ready to go. |
|
Rebased. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 28, 2017
Add a feature for dithering In order to help pass all the reftests for enabling gradients by default in Gecko, it would be nice to be able to disable dithering. Canvas2D gradients and border gradients in Gecko don't use dithering, and that causes some issues. Enabling dithering can be investigated as a follow up. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1172) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eqrion commentedApr 27, 2017
•
edited by larsbergstrom
In order to help pass all the reftests for enabling gradients by default in
Gecko, it would be nice to be able to disable dithering. Canvas2D gradients
and border gradients in Gecko don't use dithering, and that causes some
issues. Enabling dithering can be investigated as a follow up.
This change is